linux-kernel - Re: [PATCH] iommu/amd: remove unused variable flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171025235446.3ab07cfb@t450s.home>
Date:   Wed, 25 Oct 2017 23:54:46 +0200
From:   Alex Williamson <alex.williamson@...hat.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Joerg Roedel <joro@...tes.org>, iommu@...ts.linux-foundation.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/amd: remove unused variable flush_addr

On Sun, 22 Oct 2017 13:49:45 +0200
Colin King <colin.king@...onical.com> wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable flush_addr is being assigned but is never read; it
> is redundant and can be removed. Cleans up the clang warning:
> 
> drivers/iommu/amd_iommu.c:2388:2: warning: Value stored to 'flush_addr'
> is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/iommu/amd_iommu.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> index 5a72f40d6532..a99d41fc3a1d 100644
> --- a/drivers/iommu/amd_iommu.c
> +++ b/drivers/iommu/amd_iommu.c
> @@ -2382,11 +2382,9 @@ static void __unmap_single(struct dma_ops_domain *dma_dom,
>  			   size_t size,
>  			   int dir)
>  {
> -	dma_addr_t flush_addr;
>  	dma_addr_t i, start;
>  	unsigned int pages;
>  
> -	flush_addr = dma_addr;
>  	pages = iommu_num_pages(dma_addr, size, PAGE_SIZE);
>  	dma_addr &= PAGE_MASK;
>  	start = dma_addr;

Applied to iommu/updates for v4.15, thanks,

Alex