linux-kernel - Re: [PATCH 0/2] Fix s5p-mfc lock contention in request firmware paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Oct 2017 08:58:05 +1030
From:   Marian Mihailescu <marian.mihailescu@...laide.edu.au>
To:     Shuah Khan <shuahkh@....samsung.com>
Cc:     kyungmin.park@...sung.com, kamil@...as.org, jtp.park@...sung.com,
        Andrzej Hajda <a.hajda@...sung.com>, mchehab@...nel.org,
        linux-arm-kernel@...ts.infradead.org,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] Fix s5p-mfc lock contention in request firmware paths

Hi Shuah,

For MFC patch, you can delete the "dev" variable since it's not being
used anymore and results in a compile warning.

- struct s5p_mfc_dev *dev = ctx->dev;

Cheers,
Marian

On Thu, Oct 26, 2017 at 7:54 AM, Shuah Khan <shuahkh@....samsung.com> wrote:
> On 10/06/2017 03:30 PM, Shuah Khan wrote:
>> This patch series fixes inefficiencies and lock contention in the request
>> firmware paths.
>>
>> Shuah Khan (2):
>>   media: s5p-mfc: check for firmware allocation before requesting
>>     firmware
>>   media: s5p-mfc: fix lock confection - request_firmware() once and keep
>>     state
>>
>>  drivers/media/platform/s5p-mfc/s5p_mfc.c        |  4 ++++
>>  drivers/media/platform/s5p-mfc/s5p_mfc_common.h |  3 +++
>>  drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c   | 15 ++++++++++-----
>>  3 files changed, 17 insertions(+), 5 deletions(-)
>>
>
> Any feedback on this series?
>
> thanks,
> -- Shuah