linux-kernel - Re: [PATCH] coccinelle: fix verbose message about .cocci file being run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Oct 2017 09:22:59 +0200
From:   "Nicolas Palix (LIG)" <Nicolas.Palix@...g.fr>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        cocci@...teme.lip6.fr, linux-kbuild@...r.kernel.org,
        Julia Lawall <Julia.Lawall@...6.fr>
Cc:     linux-kernel@...r.kernel.org,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Michal Marek <michal.lkml@...kovi.net>
Subject: Re: [PATCH] coccinelle: fix verbose message about .cocci file being
 run

Le 26/10/17 à 06:55, Masahiro Yamada a écrit :
> If you run coccicheck with V=1 and COCCI=, you will see a strange
> path to the semantic patch file.  For example, run the following:
> 
> $ make V=1 COCCI=scripts/coccinelle/free/kfree.cocci coccicheck
>    [ snip ]
>   The semantic patch that makes this report is available
>   in scriptcoccinelle/free/kfree.cocci.
> 
> Notice "s/" was dropped from "scripts/coccinelle/free/kfree.cocci".
> 
> When running coccicheck without O=, $srctree is expanded to ".", which
> represents one arbitrary character in the regular expression.  Using
> sed is not a good choice here.  Strip $srctree/ simply without sed.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
Acked-by: Nicolas Palix <nicolas.palix@...g.fr>
> ---
> 
>   scripts/coccicheck | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index 1bfa2d2..9d18662 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -186,7 +186,7 @@ coccinelle () {
>   
>       if [ $VERBOSE -ne 0 -a $ONLINE -eq 0 ] ; then
>   
> -	FILE=`echo $COCCI | sed "s|$srctree/||"`
> +	FILE=${COCCI#$srctree/}
>   
>   	echo "Processing `basename $COCCI`"
>   	echo "with option(s) \"$OPT\""
> 


-- 
Nicolas Palix
http://lig-membres.imag.fr/palix/


Download attachment "smime.p7s" of type "application/pkcs7-signature" (2959 bytes)