linux-kernel - Re: [PATCH] MIPS: Boston: Fix earlycon baud rate selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6247cb1a-f32b-cdd1-0f8d-de619a7b3cb8@mips.com>
Date:   Thu, 26 Oct 2017 13:07:07 +0100
From:   Matt Redfearn <matt.redfearn@...s.com>
To:     Paul Burton <Paul.Burton@...s.com>,
        Ralf Baechle <ralf@...ux-mips.org>
CC:     "linux-mips@...ux-mips.org" <linux-mips@...ux-mips.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Paul Burton <paul.burton@...tec.com>,
        Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] MIPS: Boston: Fix earlycon baud rate selection

Hi Paul,


On 25/10/17 23:09, Paul Burton wrote:
> Hi Matt,
>
> On Tuesday, October 17, 2017 at 6:28 AM Matt Redfearn wrote:
>> During set up of the early console, the earlycon driver will attempt to
>> configure a baud rate, if one is set in the earlycon structure.
>> Previously, of_setup_earlycon left this field as 0, ignoring any baud
>> rate selected by the DT. Commit 31cb9a8575ca ("earlycon: initialise baud
>> field of earlycon device structure") changed this behaviour such that
>> any selected baud rate is now set. The earlycon driver must deduce the
>> divisor from the configured uartclk, which of_setup_earlycon sets to
>> BASE_BAUD. MIPS generic kernels do not set BASE_BAUD (there is no
>> practical way to set this generically for all supported platforms), so
>> when the early console is configured an incorrect divisor is calculated
>> for the selected baud rate, and garbage is printed to the console during
>> boot.
>>
>> Fix this by removing the configured baud rate from the device tree.
>> This causes the early console to inherit the baud rate settings from the
>> bootloader. By the time the real console is probed, the clock drivers
>> necessary to calculate the divisor are enabled and the kernel can
>> correctly configure the baud rate.
> Sadly I think this breaks the proper console - my current understanding
> is that we end up with it set to 9600 baud due to the defaults in
> serial8250_console_setup(). So with your patch I see correct output from
> the early console, then nothing when the proper console registers until
> my userland starts a getty on ttyS0 which reconfigures it to 115200 baud.

As long as you specify "console=ttyS0,115200" on the command line, then 
the correct baud rate gets applied. I know that's not ideal...

(CC'ing Eugene & Greg KH for other ideas to fix this)

Thanks,
Matt

>
> Thanks,
>      Paul
>
>> Fixes: 31cb9a8575ca ("earlycon: initialise baud field of earlycon device
>> structure")
>> Signed-off-by: Matt Redfearn <matt.redfearn@...s.com>
>>
>> ---
>>
>>   arch/mips/boot/dts/img/boston.dts | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/boot/dts/img/boston.dts
>> b/arch/mips/boot/dts/img/boston.dts
>> index 53bfa29a7093..179691aae7d7 100644
>> --- a/arch/mips/boot/dts/img/boston.dts
>> +++ b/arch/mips/boot/dts/img/boston.dts
>> @@ -11,7 +11,7 @@
>>   	compatible = "img,boston";
>>
>>   	chosen {
>> -		stdout-path = "uart0:115200";
>> +		stdout-path = "uart0";
>>   	};
>>
>>   	aliases {
>> --
>> 2.7.4