linux-kernel - Re: [PATCH 1/4] usb: xhci: remove unused variable last_freed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171026122055.GB26709@Red>
Date:   Thu, 26 Oct 2017 14:20:55 +0200
From:   LABBE Corentin <clabbe@...libre.com>
To:     mathias.nyman@...el.com, gregkh@...uxfoundation.org
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] usb: xhci: remove unused variable last_freed_endpoint

On Thu, Oct 26, 2017 at 12:01:54PM +0000, Corentin Labbe wrote:
> This patch fix the following build warnings:
> drivers/usb/host/xhci.c:3378:6: warning: variable 'last_freed_endpoint' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Corentin Labbe <clabbe@...libre.com>
> ---
>  drivers/usb/host/xhci.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index ee077a2..b12b2bd 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -3375,7 +3375,6 @@ static int xhci_discover_or_reset_device(struct usb_hcd *hcd,
>  	unsigned int slot_id;
>  	struct xhci_virt_device *virt_dev;
>  	struct xhci_command *reset_device_cmd;
> -	int last_freed_endpoint;
>  	struct xhci_slot_ctx *slot_ctx;
>  	int old_active_eps = 0;
>  
> @@ -3490,7 +3489,6 @@ static int xhci_discover_or_reset_device(struct usb_hcd *hcd,
>  	}
>  
>  	/* Everything but endpoint 0 is disabled, so free the rings. */
> -	last_freed_endpoint = 1;
>  	for (i = 1; i < 31; i++) {
>  		struct xhci_virt_ep *ep = &virt_dev->eps[i];
>  
> @@ -3505,7 +3503,6 @@ static int xhci_discover_or_reset_device(struct usb_hcd *hcd,
>  		if (ep->ring) {
>  			xhci_debugfs_remove_endpoint(xhci, virt_dev, i);
>  			xhci_free_endpoint_ring(xhci, virt_dev, i);
> -			last_freed_endpoint = i;
>  		}
>  		if (!list_empty(&virt_dev->eps[i].bw_endpoint_list))
>  			xhci_drop_ep_from_interval_table(xhci,
> -- 
> 2.7.4
> 

I apologize, I have make some mistake in my send.

Sorry

Regards