lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 26 Oct 2017 09:52:42 -0400
From:   Brian Gerst <brgerst@...il.com>
To:     Andy Lutomirski <luto@...nel.org>
Cc:     X86 ML <x86@...nel.org>, Borislav Petkov <bpetkov@...e.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Dave Hansen <dave.hansen@...el.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 03/18] x86/asm/64: Move SWAPGS into the common
 iret-to-usermode path

On Thu, Oct 26, 2017 at 4:26 AM, Andy Lutomirski <luto@...nel.org> wrote:
> All of the code paths that ended up doing IRET to usermode did
> SWAPGS immediately beforehand.  Move the SWAPGS into the common
> code.
>
> Signed-off-by: Andy Lutomirski <luto@...nel.org>

> +GLOBAL(swapgs_restore_regs_and_return_to_usermode)

Is adding swapgs to the label really necessary?  It's redundant with
the usermode part.  I'm noticing a trend towards absurdly verbose
labels lately.

--
Brian Gerst

Powered by blists - more mailing lists