linux-kernel - Re: [PATCH] platform/x86: dell-uart-backlight: new backlight driver for DELL AIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171026171011.3eca122e@alans-desktop>
Date:   Thu, 26 Oct 2017 17:10:11 +0100
From:   Alan Cox <gnomes@...rguk.ukuu.org.uk>
To:     <Mario.Limonciello@...l.com>
Cc:     <acelan.kao@...onical.com>, <dvhart@...radead.org>,
        <andy@...radead.org>, <linux-kernel@...r.kernel.org>,
        <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: dell-uart-backlight: new backlight driver
 for DELL AIO


> > +static int __init dell_uart_bl_init(void)
> > +{
> > +	ftty = filp_open("/dev/ttyS0", O_RDWR | O_NOCTTY | O_NDELAY, 0);  
> 

You have no idea what name is assigned. This doesn't work.

This isn't the way to do it any more because the 'tty from kernel'
problem finally got fixed. You can attach it as a serdev directly to the
kernel.

Take a look at serdev_tty_port_register/serdev_tty_port_unreg

Alan