linux-kernel - Re: [PATCH] iio/pressure/hp206c: Use common error handling code in hp206c_conv_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Oct 2017 17:23:45 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-iio@...r.kernel.org,
        Crestez Dan Leonard <leonard.crestez@...el.com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] iio/pressure/hp206c: Use common error handling code in
 hp206c_conv_and_read()

On Thu, 26 Oct 2017 15:45:43 +0200
SF Markus Elfring <elfring@...rs.sourceforge.net> wrote:

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 26 Oct 2017 15:34:46 +0200
> 
> Add a jump target so that a specific error message is stored only once
> at the end of this function implementation.
> Replace two calls of the function "dev_err" by goto statements.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

The advantages of this are very limited. Hence I am not going to
apply it.

There would be some argument (perhaps) for moving the error message
into the function being called but that would then make the driver
inconsistent on where it reports errors reducing overall readability.

Jonathan

> ---
>  drivers/iio/pressure/hp206c.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/iio/pressure/hp206c.c b/drivers/iio/pressure/hp206c.c
> index c38c19678cf6..978338f2a6e5 100644
> --- a/drivers/iio/pressure/hp206c.c
> +++ b/drivers/iio/pressure/hp206c.c
> @@ -176,10 +176,8 @@ static int hp206c_conv_and_read(struct iio_dev *indio_dev,
>  	struct i2c_client *client = data->client;
>  
>  	ret = hp206c_wait_dev_rdy(indio_dev);
> -	if (ret < 0) {
> -		dev_err(&indio_dev->dev, "Device not ready: %d\n", ret);
> -		return ret;
> -	}
> +	if (ret < 0)
> +		goto report_failure;
>  
>  	ret = i2c_smbus_write_byte(client, conv_cmd);
>  	if (ret < 0) {
> @@ -190,16 +188,18 @@ static int hp206c_conv_and_read(struct iio_dev *indio_dev,
>  	usleep_range(sleep_us, sleep_us * 3 / 2);
>  
>  	ret = hp206c_wait_dev_rdy(indio_dev);
> -	if (ret < 0) {
> -		dev_err(&indio_dev->dev, "Device not ready: %d\n", ret);
> -		return ret;
> -	}
> +	if (ret < 0)
> +		goto report_failure;
>  
>  	ret = hp206c_read_20bit(client, read_cmd);
>  	if (ret < 0)
>  		dev_err(&indio_dev->dev, "Failed read: %d\n", ret);
>  
>  	return ret;
> +
> +report_failure:
> +	dev_err(&indio_dev->dev, "Device not ready: %d\n", ret);
> +	return ret;
>  }
>  
>  static int hp206c_read_raw(struct iio_dev *indio_dev,