linux-kernel - Re: [PATCH] iio/light/max44000: Use common error handling code in max44000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Oct 2017 18:50:14 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org
Cc:     Akinobu Mita <akinobu.mita@...il.com>,
        Crestez Dan Leonard <leonard.crestez@...el.com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] iio/light/max44000: Use common error handling code in
 max44000_probe()

>> @@ -596,6 +592,10 @@ static int max44000_probe(struct i2c_client *client,
>>  	}
>>  
>>  	return iio_device_register(indio_dev);
>> +
>> +report_failure:
>> +	dev_err(&client->dev, "failed to write init config: %d\n", ret);
> This reduces readability of the code for a very minor gain.

I got an other software development view on this aspect.


> Printing an error message is not a source of bugs

I find such a general information questionable.

It is also possible to discover various update candidates in this software area.


> or similar unlike unwinding some state, so a unified path makes little sense.

How does such a view fit to the section “7) Centralized exiting of functions”
in the document “coding-style.rst”?

Regards,
Markus