linux-kernel - Re: [PATCH cgroup/for-4.15] cgroup, sched: Move basic cpu stats from cgroup.stat to cpu.stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171026174307.GU3165@worktop.lehotels.local>
Date:   Thu, 26 Oct 2017 19:43:07 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Tejun Heo <tj@...nel.org>
Cc:     Li Zefan <lizefan@...wei.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Ingo Molnar <mingo@...hat.com>, Roman Gushchin <guro@...com>,
        linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
        kernel-team@...com
Subject: Re: [PATCH cgroup/for-4.15] cgroup, sched: Move basic cpu stats from
 cgroup.stat to cpu.stat

On Mon, Oct 23, 2017 at 04:18:27PM -0700, Tejun Heo wrote:
> The basic cpu stat is currently shown with "cpu." prefix in
> cgroup.stat, and the same information is duplicated in cpu.stat when
> cpu controller is enabled.  This is ugly and not very scalable as we
> want to expand the coverage of stat information which is always
> available.
> 
> This patch makes cgroup core always create "cpu.stat" file and show
> the basic cpu stat there and calls the cpu controller to show the
> extra stats when enabled.  This ensures that the same information
> isn't presented in multiple places and makes future expansion of basic
> stats easier.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>

>  Documentation/cgroup-v2.txt     |   15 +++-------
>  include/linux/cgroup-defs.h     |    2 +
>  include/linux/cgroup.h          |    2 -
>  kernel/cgroup/cgroup-internal.h |    1 
>  kernel/cgroup/cgroup.c          |   60 ++++++++++++++++++++++++++++++++++++++--
>  kernel/cgroup/stat.c            |   10 +++---
>  kernel/sched/core.c             |   13 ++------
>  7 files changed, 75 insertions(+), 28 deletions(-)

Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>