linux-kernel - Re: [PATCH v2] i2c: aspeed: Deassert reset in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171026205348.zh2gicql4pyyeoaa@ninjato>
Date:   Thu, 26 Oct 2017 22:53:48 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Philipp Zabel <philipp.zabel@...il.com>
Cc:     Joel Stanley <joel@....id.au>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Andrew Jeffery <andrew@...id.au>, linux-i2c@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] i2c: aspeed: Deassert reset in probe

> > +       bus->rst = devm_reset_control_get_optional_shared(&pdev->dev, NULL);
> 
> This could return error values in case of broken device trees, so you
> may want to check IS_ERR(bus->rst) and handle the error here.
> 
> > +       reset_control_deassert(bus->rst);
> 
> Otherwise this will dump a warning.
> 
> > +
> >         ret = of_property_read_u32(pdev->dev.of_node,
> >                                    "bus-frequency", &bus->bus_frequency);
> >         if (ret < 0) {
> > @@ -919,6 +925,8 @@ static int aspeed_i2c_remove_bus(struct platform_device *pdev)
> >
> >         i2c_del_adapter(&bus->adap);
> >
> > +       reset_control_assert(bus->rst);
> 
> As will this.
> 
> Reviewed-by: Philipp Zabel <philipp.zabel@...il.com>

Joel, do you want to fix it? I'd think it makes sense...


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)