lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 26 Oct 2017 07:00:36 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     David Daney <ddaney@...iumnetworks.com>,
        David Daney <david.daney@...ium.com>, linux-i2c@...r.kernel.org
Cc:     Jan Glauber <jglauber@...ium.com>,
        Wolfram Sang <wsa@...-dreams.de>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: I2C-Octeon: Use common error handling code in octeon_i2c_probe()

> NAK.  We don't need any more Markus Elfring spam.

Why do you not like another update suggestion for this use case?


>> Add a jump target so that a specific error message is stored only once
>> at the end of this function implementation.
> 
> Please read C standard about duplicate literal strings to see
> why this is a completely misleading and false statement.

* I proposed to adjust the position for one function call, didn't I?

* Do you care for a bit of code reduction?

* Do you prefer to use an optimisation option like “-fmerge-constants”
  (instead of integrating the shown small change)?

Regards,
Markus

Powered by blists - more mailing lists