linux-kernel - Re: [PATCH v5 9/9] block: Assign a lock_class per gendisk used for wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Oct 2017 07:50:46 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     Byungchul Park <byungchul.park@....com>, peterz@...radead.org,
        johan@...nel.org, tglx@...utronix.de, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, tj@...nel.org, johannes.berg@...el.com,
        oleg@...hat.com, amir73il@...il.com, david@...morbit.com,
        darrick.wong@...cle.com, linux-xfs@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-block@...r.kernel.org,
        hch@...radead.org, idryomov@...il.com, kernel-team@....com
Subject: Re: [PATCH v5 9/9] block: Assign a lock_class per gendisk used for
 wait_for_completion()


* Jens Axboe <axboe@...nel.dk> wrote:

> On 10/25/2017 03:13 AM, Ingo Molnar wrote:
> > 
> > * Byungchul Park <byungchul.park@....com> wrote:
> > 
> >> Darrick posted the following warning and Dave Chinner analyzed it:
> >>
> >>> ======================================================
> >>> WARNING: possible circular locking dependency detected
> >>> 4.14.0-rc1-fixes #1 Tainted: G        W
> > 
> >> Reported-by: Darrick J. Wong <darrick.wong@...cle.com>
> >> Analyzed-by: Dave Chinner <david@...morbit.com>
> >> Signed-off-by: Byungchul Park <byungchul.park@....com>
> >> ---
> >>  block/bio.c           |  2 +-
> >>  block/genhd.c         | 10 ++--------
> >>  include/linux/genhd.h | 22 ++++++++++++++++++++--
> >>  3 files changed, 23 insertions(+), 11 deletions(-)
> > 
> > Ok, this patch looks good to me now, I'll wait to get an Ack or Nak from Jens for 
> > these changes.
> > 
> > Jens: this patch has some dependencies in prior lockdep changes, so I'd like to 
> > carry it in the locking tree for a v4.15 merge.
> 
> Looks fine to me, you can add my reviewed-by and carry it in your tree.

Thanks Jens!

	Ingo