lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 26 Oct 2017 17:27:34 +1100
From:   "Tobin C. Harding" <>
To:     Joe Perches <>
        "Jason A. Donenfeld" <>,
        Theodore Ts'o <>,
        Linus Torvalds <>,
        Kees Cook <>,
        Paolo Bonzini <>,
        Tycho Andersen <>,
        "Roberts, William C" <>,
        Tejun Heo <>,
        Jordan Glover <>,
        Greg KH <>,
        Petr Mladek <>,
        Ian Campbell <>,
        Sergey Senozhatsky <>,
        Catalin Marinas <>,
        Will Deacon <>,
        Steven Rostedt <>,
        Chris Fries <>,
        Dave Weinstein <>,
        Daniel Micay <>,
        Djalal Harouni <>,
Subject: Re: [PATCH V8 1/2] printk: remove tabular output for NULL pointer

Hi Joe,

thanks for your review.

On Wed, Oct 25, 2017 at 09:57:23PM -0700, Joe Perches wrote:
> On Thu, 2017-10-26 at 13:53 +1100, Tobin C. Harding wrote:
> > Currently pointer() checks for a NULL pointer argument and then if so
> > attempts to print "(null)" with _some_ standard width. This width cannot
> > correctly be ascertained here because many of the printk specifiers
> > print pointers of varying widths.
> I believe this is not a good change.
> Only pointers without a <foo> extension call pointer()

Sorry, I don't understand what you mean here. All the %p<foo> specifier code is
handled by pointer()?

> > Remove the attempt to print NULL pointers with a correct width.
> the correct width for a %p is the default width.

It is the default width if we are printing addresses. Once we hash 64
bit address to a 32 bit identifier then we don't have a default width.

> The correct width for %p<foo> is unknown.

I agree.

If I have misunderstood you, please forgive me. I am very appreciative
of the reviews this patch is getting and the patience the list is having
with the many iterations.


Powered by blists - more mailing lists