linux-kernel - Re: [PATCH] net: tipc: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jKzCDeW2UaEB4EK2uy4wjC6TidFQtSTj0-F2jLYgZXq0A@mail.gmail.com>
Date:   Fri, 27 Oct 2017 06:58:00 +0200
From:   Kees Cook <keescook@...omium.org>
To:     Jon Maloy <jon.maloy@...csson.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Ying Xue <ying.xue@...driver.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "tipc-discussion@...ts.sourceforge.net" 
        <tipc-discussion@...ts.sourceforge.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: tipc: Convert timers to use timer_setup()

On Tue, Oct 24, 2017 at 11:44 AM, Jon Maloy <jon.maloy@...csson.com> wrote:
> NAK. It doesn't sound like a good idea to send this to net. Especially since one of these timers has already been refactored in net-next.

Hi! I'm not sure what you mean about the one timer issue. I don't see
any use of timer_setup() in net/tipc (and no recent conversions to the
older setup_timer() API). What's the preferred path for landing this
API conversion in net/tipc/?

And, just to note, these changes are almost entirely mechanical. The
only "special" case is in tipc_sk_timeout() where the argument needs
to be slightly adjusted to fetch the tsk from the sk again.

Thanks!

-Kees

-- 
Kees Cook
Pixel Security