linux-kernel - Re: [PATCH 01/12] Input: ad7897 - use managed devm_device_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <20171027061107.GC29398@gangnam>
Date:   Fri, 27 Oct 2017 15:11:07 +0900
From:   Andi Shyti <andi.shyti@...sung.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Andi Shyti <andi@...zian.org>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Michael Hennerich <michael.hennerich@...log.com>
Subject: Re: [PATCH 01/12] Input: ad7897 - use managed devm_device_add_group

Hi Dmitry,

> > Commit 57b8ff070f98 ("driver core: add devm_device_add_group()
> > and friends") has added the the managed version for creating
> > sysfs group files.
> > 
> > Use devm_device_add_group instead of sysfs_create_group and
> > remove the relative sysfs_remove_group and goto label.
> > 
> > CC: Michael Hennerich <michael.hennerich@...log.com>
> > Signed-off-by: Andi Shyti <andi@...zian.org>
> > ---
> >  drivers/input/touchscreen/ad7877.c | 8 ++------
> >  1 file changed, 2 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c
> > index 9c250ae780d9..677ba38b4d1c 100644
> > --- a/drivers/input/touchscreen/ad7877.c
> > +++ b/drivers/input/touchscreen/ad7877.c
> > @@ -783,18 +783,16 @@ static int ad7877_probe(struct spi_device *spi)
> >  		goto err_free_mem;
> >  	}
> >  
> > -	err = sysfs_create_group(&spi->dev.kobj, &ad7877_attr_group);
> > +	err = devm_device_add_group(&spi->dev, &ad7877_attr_group);
> 
> This changes order of operations and ultimately may cause use-after-free
> as memory for ad7877 structure will be freed before we remove
> attributes.

yes, right... sorry... was too fast at making these patches :)
I'll send a second version over the weekend.

Andi