linux-kernel - Re: [PATCH] x86/alternatives: free smp_alt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171027074912.GB1305@nazgul.tnic>
Date:   Fri, 27 Oct 2017 09:49:12 +0200
From:   Borislav Petkov <bp@...e.de>
To:     Zhou Chengming <zhouchengming1@...wei.com>
Cc:     mingo@...hat.com, tglx@...utronix.de, peterz@...radead.org,
        hpa@...or.com, jkosina@...e.cz, rostedt@...dmis.org,
        mjurczyk@...gle.com, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/alternatives: free smp_alt_modules when enable smp

On Fri, Oct 27, 2017 at 03:18:12PM +0800, Zhou Chengming wrote:
> In the current code, we don't free smp_alt_modules when enable smp,
> so have to wait module unload to call alternatives_smp_module_del()
> to free its smp_alt_module. This strategy has shortcomings.

I love it when the commit message states there is allegedly some problem
but it doesn't explain what that problem is.

>From the looks of the patch, though, I'd prefer what we do now and not
touch the code.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--