linux-kernel - Re: [V2] bcma: Use bcma_debug and not pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171027080150.60B1C6034E@smtp.codeaurora.org>
Date:   Fri, 27 Oct 2017 08:01:50 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Rafał Miłecki <zajec5@...il.com>,
        Hauke Mehrtens <hauke@...ke-m.de>,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [V2] bcma: Use bcma_debug and not pr_cont in MIPS driver

Joe Perches <joe@...ches.com> wrote:

> Commit 66cc04424960 ("bcma: use bcma_debug and pr_cont in MIPS driver")
> converted a printk(KERN_DEBUG to bcma_debug.
> 
> bcma_debug is guarded by a #define DEBUG via pr_debug.
> 
> This means that the bcma_debug will generally not be emitted
> but any pr_cont following the bcma_debug will be emitted.
> 
> Correct this by removing the uses of pr_cont by using a temporary.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Patch applied to wireless-drivers-next.git, thanks.

758f7e06063a bcma: Use bcma_debug and not pr_cont in MIPS driver

-- 
https://patchwork.kernel.org/patch/10016013/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches