linux-kernel - Re: [PATCH 5/9] staging: lustre: ldlm: remove unused 'overlaps' variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77ADF410-2FBC-4F06-B5C5-275EE18D703D@intel.com>
Date:   Fri, 27 Oct 2017 09:20:31 +0000
From:   "Dilger, Andreas" <andreas.dilger@...el.com>
To:     NeilBrown <neilb@...e.com>
CC:     "Drokin, Oleg" <oleg.drokin@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "lustre-devel@...ts.lustre.org" <lustre-devel@...ts.lustre.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/9] staging: lustre: ldlm: remove unused 'overlaps'
 variable

On Oct 22, 2017, at 18:53, NeilBrown <neilb@...e.com> wrote:
> 
> 'overlaps' is never used, only incremented.
> 
> Signed-off-by: NeilBrown <neilb@...e.com>

Reviewed-by: Andreas Dilger <andreas.dilger@...el.com>

> ---
> drivers/staging/lustre/lustre/ldlm/ldlm_flock.c |    3 ---
> 1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c
> index 2d1fa2b33129..d5a5742a1171 100644
> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c
> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c
> @@ -133,7 +133,6 @@ static int ldlm_process_flock_lock(struct ldlm_lock *req)
> 	struct ldlm_lock *new2 = NULL;
> 	enum ldlm_mode mode = req->l_req_mode;
> 	int added = (mode == LCK_NL);
> -	int overlaps = 0;
> 	int splitted = 0;
> 	const struct ldlm_callback_suite null_cbs = { };
> 
> @@ -226,8 +225,6 @@ static int ldlm_process_flock_lock(struct ldlm_lock *req)
> 		    lock->l_policy_data.l_flock.start)
> 			break;
> 
> -		++overlaps;
> -
> 		if (new->l_policy_data.l_flock.start <=
> 		    lock->l_policy_data.l_flock.start) {
> 			if (new->l_policy_data.l_flock.end <
> 
> 

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation