linux-kernel - Re: drivers/wireless: ath: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jLY0nUOXThRUa_q7h2JRSBp_YSFQGF19+EhZ4Q_kFLqQg@mail.gmail.com>
Date:   Fri, 27 Oct 2017 11:29:08 +0200
From:   Kees Cook <keescook@...omium.org>
To:     Kalle Valo <kvalo@....qualcomm.com>
Cc:     Kalle Valo <kvalo@...eaurora.org>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: drivers/wireless: ath: Convert timers to use timer_setup()

On Fri, Oct 27, 2017 at 11:18 AM, Kalle Valo <kvalo@....qualcomm.com> wrote:
> Kees Cook <keescook@...omium.org> wrote:
>
>> In preparation for unconditionally passing the struct timer_list pointer to
>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>> to pass the timer pointer explicitly.
>>
>> Cc: Kalle Valo <kvalo@....qualcomm.com>
>> Cc: linux-wireless@...r.kernel.org
>> Cc: netdev@...r.kernel.org
>> Signed-off-by: Kees Cook <keescook@...omium.org>
>> Signed-off-by: Kalle Valo <kvalo@....qualcomm.com>
>
> There were some conflicts but luckily 3-way merge was able to automatically
> solve them. But please do check the patch from my pending branch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=dd08329d31a4c150f8aab8274033901baaf3e923

This looks correct to me, thanks for merging!

-Kees

-- 
Kees Cook
Pixel Security