lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9ae1759e-18a1-18fb-ec93-8edf947b1cc6@huawei.com>
Date:   Fri, 27 Oct 2017 17:32:42 +0800
From:   Yunsheng Lin <linyunsheng@...wei.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Ariel Elior <Ariel.Elior@...ium.com>
CC:     <everest-linux-l2@...ium.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH net-next] qed: Set error code for allocation failures

Hi, Dan

On 2017/10/27 14:40, Dan Carpenter wrote:
> There are several places where we accidentally return success when
> kcalloc() fails.
> 
> Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and processing mpa fpdus")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> index 409041eab189..6366f2ef82b7 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> @@ -2585,7 +2585,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,
>  	struct qed_ll2_cbs cbs;
>  	u32 mpa_buff_size;
>  	u16 n_ooo_bufs;
> -	int rc = 0;
> +	int rc;
>  	int i;
>  
>  	iwarp_info = &p_hwfn->p_rdma_info->iwarp;
> @@ -2696,6 +2696,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,
>  	if (rc)
>  		goto err;
>  
> +	rc = -ENOMEM;
>  	iwarp_info->partial_fpdus = kcalloc((u16)p_hwfn->p_rdma_info->num_qps,
>  					    sizeof(*iwarp_info->partial_fpdus),
>  					    GFP_KERNEL);

Does the memory allocated here need to be freed when error happens below?


> @@ -2724,7 +2725,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,
>  	for (i = 0; i < data.input.rx_num_desc; i++)
>  		list_add_tail(&iwarp_info->mpa_bufs[i].list_entry,
>  			      &iwarp_info->mpa_buf_list);
> -	return rc;
> +	return 0;
>  err:
>  	qed_iwarp_ll2_stop(p_hwfn, p_ptt);
>  
> 
> .
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ