linux-kernel - Re: [lustre-devel] [PATCH 9/9] staging: lustre: ldlm: remove unused field 'fwd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C206A005-681E-462C-83DB-0A9320D28CDA@intel.com>
Date:   Fri, 27 Oct 2017 09:39:01 +0000
From:   "Dilger, Andreas" <andreas.dilger@...el.com>
To:     NeilBrown <neilb@...e.com>
CC:     "Drokin, Oleg" <oleg.drokin@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lustre-devel@...ts.lustre.org" <lustre-devel@...ts.lustre.org>
Subject: Re: [lustre-devel] [PATCH 9/9] staging: lustre: ldlm: remove unused
 field 'fwd_generation'

On Oct 22, 2017, at 18:53, NeilBrown <neilb@...e.com> wrote:
> 
> With this field gone, we don't need local variables 'imp' or 'obd'
> any more.
> 
> Signed-off-by: NeilBrown <neilb@...e.com>

Thanks for the patches.

Reviewed-by: Andreas Dilger <andreas.dilger@...el.com>

> ---
> drivers/staging/lustre/lustre/ldlm/ldlm_flock.c |   21 +++------------------
> 1 file changed, 3 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c
> index 774d8667769a..9c0e9cd00000 100644
> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c
> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c
> @@ -311,7 +311,6 @@ static int ldlm_process_flock_lock(struct ldlm_lock *req)
> 
> struct ldlm_flock_wait_data {
> 	struct ldlm_lock *fwd_lock;
> -	int	       fwd_generation;
> };
> 
> static void
> @@ -342,11 +341,9 @@ int
> ldlm_flock_completion_ast(struct ldlm_lock *lock, __u64 flags, void *data)
> {
> 	struct file_lock		*getlk = lock->l_ast_data;
> -	struct obd_device	      *obd;
> -	struct obd_import	      *imp = NULL;
> -	struct ldlm_flock_wait_data     fwd;
> -	struct l_wait_info	      lwi;
> -	int			     rc = 0;
> +	struct ldlm_flock_wait_data	fwd;
> +	struct l_wait_info		lwi;
> +	int				rc = 0;
> 
> 	OBD_FAIL_TIMEOUT(OBD_FAIL_LDLM_CP_CB_WAIT2, 4);
> 	if (OBD_FAIL_PRECHECK(OBD_FAIL_LDLM_CP_CB_WAIT3)) {
> @@ -374,18 +371,6 @@ ldlm_flock_completion_ast(struct ldlm_lock *lock, __u64 flags, void *data)
> 
> 	LDLM_DEBUG(lock, "client-side enqueue returned a blocked lock, sleeping");
> 	fwd.fwd_lock = lock;
> -	obd = class_exp2obd(lock->l_conn_export);
> -
> -	/* if this is a local lock, there is no import */
> -	if (obd)
> -		imp = obd->u.cli.cl_import;
> -
> -	if (imp) {
> -		spin_lock(&imp->imp_lock);
> -		fwd.fwd_generation = imp->imp_generation;
> -		spin_unlock(&imp->imp_lock);
> -	}
> -
> 	lwi = LWI_TIMEOUT_INTR(0, NULL, ldlm_flock_interrupted_wait, &fwd);
> 
> 	/* Go to sleep until the lock is granted. */
> 
> 
> _______________________________________________
> lustre-devel mailing list
> lustre-devel@...ts.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation