linux-kernel - Re: [PATCH] iio/adc/palmas: Use common error handling code in palmas_gpadc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bcd5b722-fe10-8ea0-0f90-662cb414b4c0@users.sourceforge.net>
Date:   Fri, 27 Oct 2017 15:43:27 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org
Cc:     Alison Schofield <amsfield22@...il.com>,
        "H. Nikolaus Schaller" <hns@...delico.com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] iio/adc/palmas: Use common error handling code in
 palmas_gpadc_calibrate()

>> @@ -329,6 +325,10 @@ static int palmas_gpadc_calibrate(struct palmas_gpadc *adc, int adc_chan)
>>  
>>  scrub:
>>  	return ret;
>> +
>> +report_failure:
> 
> This makes for complex code flow where it is not needed.

The shown code layout would be required in the suggested software design direction.


> As such I am not going to even think about taking this sort of patch.

It might take more time until similar situations will be reconsidered.


>> +	dev_err(adc->dev, "TRIM read failed: %d\n", ret);
>> +	goto scrub;
>>  }
>>  
>>  static int palmas_gpadc_start_conversion(struct palmas_gpadc *adc, int adc_chan)

Do any other contributors find a bit of code reduction desirable for this
software module?

Regards,
Markus