[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20171027143020.m7zlhptw4nl2xy3n@mwanda>
Date: Fri, 27 Oct 2017 17:30:21 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Bogdan Purcareata <bogdan.purcareata@....com>
Cc: ruxandra.radulescu@....com, gregkh@...uxfoundation.org,
linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH 4/5] staging: fsl-dpaa2/eth: Change RX buffer alignment
On Fri, Oct 27, 2017 at 02:11:35PM +0000, Bogdan Purcareata wrote:
> @@ -93,10 +100,10 @@
> * buffers large enough to allow building an skb around them and also account
> * for alignment restrictions
> */
> -#define DPAA2_ETH_BUF_RAW_SIZE \
> +#define DPAA2_ETH_BUF_RAW_SIZE(priv) \
> (DPAA2_ETH_RX_BUF_SIZE + \
> SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) + \
> - DPAA2_ETH_RX_BUF_ALIGN)
> + (priv)->rx_buf_align)
>
Not related to this patch, but this macro is ugly. It would be better
as function.
regards,
dan carpenter
Powered by blists - more mailing lists