linux-kernel - Re: [PATCH] net: bcmgenet: Use BUG_ON instead of if condition followed by BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171027.235607.430416647630428682.davem@davemloft.net>
Date:   Fri, 27 Oct 2017 23:56:07 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     garsilva@...eddedor.com
Cc:     f.fainelli@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: bcmgenet: Use BUG_ON instead of if condition
 followed by BUG

From: "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Date: Thu, 26 Oct 2017 07:16:01 -0500

> Use BUG_ON instead of if condition followed by BUG.
> 
> Something to notice in this particular case is that unlikely()
> is already being called inside BUG_ON macro.
> 
> This issue was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

Applied.