linux-kernel - Re: [PATCH] iommu: Limit the IOVA page range to the specified addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <df434365-6972-f87c-c77b-f0008aa2b1c8@amd.com>
Date:   Fri, 27 Oct 2017 10:20:43 -0500
From:   Gary R Hook <gary.hook@....com>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu: Limit the IOVA page range to the specified
 addresses

On 10/26/2017 03:32 AM, Alex Williamson wrote:
> On Tue, 17 Oct 2017 16:22:01 -0500
> Gary R Hook <gary.hook@....com> wrote:
> 
>> From: amd <amd@...xen2.amd.com>
>>
>> The extent of pages specified when applying a reserved region should
>> include up to the last page of the range, but not the page following
>> the range.
>>
>> Signed-off-by: Gary R Hook <gary.hook@....com>
>> ---
>>   drivers/iommu/amd_iommu.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
>> index 27eb0d6fcdc2..bb3ef33e3784 100644
>> --- a/drivers/iommu/amd_iommu.c
>> +++ b/drivers/iommu/amd_iommu.c
>> @@ -3271,7 +3271,7 @@ static void amd_iommu_apply_resv_region(struct device *dev,
>>   	unsigned long start, end;
>>   
>>   	start = IOVA_PFN(region->start);
>> -	end   = IOVA_PFN(region->start + region->length);
>> +	end   = IOVA_PFN(region->start + region->length - 1);
>>   
>>   	WARN_ON_ONCE(reserve_iova(&dma_dom->iovad, start, end) == NULL);
>>   }
> 
> This looks like a fix, should we include:
> 
> Fixes: 8d54d6c8b8f3 ('iommu/amd: Implement apply_dm_region call-back')

It turns out there are other places where the computation is incorrect.
Would you prefer a single patch to address all of them, or separate
patches that apply to specific areas of the driver?