linux-kernel - Re: [PATCH] platform/x86: silead_dmi: Fix GP-electronic T701 entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeAKSjFCEUoJWc6BmZiu70HS4Exw0p2=qwC2B09i9CwOg@mail.gmail.com>
Date:   Fri, 27 Oct 2017 19:48:25 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: silead_dmi: Fix GP-electronic T701 entry

On Thu, Oct 19, 2017 at 10:44 AM, Hans de Goede <hdegoede@...hat.com> wrote:
> The GP-electronic T701 has its LCD panel mounted upside-down, initially
> my plan was to fix this by transparently rotating the image in the i915
> driver (my "drm/i915: Deal with upside-down mounted LCD" patch), but
> that approach has been rejected instead the kernel will now export
> a "panel orientation" property on the drm-connector for the panel and
> let userspace deal with it.
>
> But userspace expects the touchscreen coordinates to match the panel
> coordinates *before* applying any rotation, so now that we no longer hide
> the upside-down-ness of the LCD panel from userspace the coordinates being
> generated are wrong and we need to apply a rotation of 180 degrees to the
> coordinates to fix this.
>

Pushed to my review and testing queue, thanks!

> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> ---
>  drivers/platform/x86/silead_dmi.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c
> index a0f80f971081..ac304f2318cc 100644
> --- a/drivers/platform/x86/silead_dmi.c
> +++ b/drivers/platform/x86/silead_dmi.c
> @@ -85,6 +85,8 @@ static const struct silead_ts_dmi_data surftab_wintron70_st70416_6_data = {
>  static const struct property_entry gp_electronic_t701_props[] = {
>         PROPERTY_ENTRY_U32("touchscreen-size-x", 960),
>         PROPERTY_ENTRY_U32("touchscreen-size-y", 640),
> +       PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
> +       PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
>         PROPERTY_ENTRY_STRING("firmware-name",
>                               "gsl1680-gp-electronic-t701.fw"),
>         { }
> --
> 2.14.2
>



-- 
With Best Regards,
Andy Shevchenko