linux-kernel - [PATCH] init/main.c: check for null pointer before calling initcall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1509122847.11787.5.camel@polymtl.ca>
Date:   Fri, 27 Oct 2017 12:47:27 -0400
From:   Abderrahmane Benbachir <abderrahmane.benbachir@...ymtl.ca>
To:     linux-kernel@...r.kernel.org
Cc:     mingo@...nel.org, akpm@...ux-foundation.org, tglx@...utronix.de,
        keescook@...omium.org, jeyu@...hat.com, rostedt@...dmis.org,
        mhocko@...e.com, viresh.kumar@...aro.org, thomas.lendacky@....com
Subject: [PATCH] init/main.c: check for null pointer before calling initcall

Simple check to prevent kernel panic when initcall does not exit

Signed-off-by: Abderrahmane Benbachir <abderrahmane.benbachir@...ymtl.ca>
---
 init/main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/init/main.c b/init/main.c
index 0ee9c6866ada..220fd2822b61 100644
--- a/init/main.c
+++ b/init/main.c
@@ -817,6 +817,9 @@ int __init_or_module do_one_initcall(initcall_t fn)
 	int ret;
 	char msgbuf[64];
 
+	if (unlikely(!fn))
+		return -EFAULT;
+
 	if (initcall_blacklisted(fn))
 		return -EPERM;
 
-- 
2.11.0