linux-kernel - Re: [PATCH] platform/x86: dell-uart-backlight: new backlight driver for DELL AIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Ve6f7zcD3jNCcRFj1reMg5wupzgJEHBmSH5S6-R0_apNQ@mail.gmail.com>
Date:   Fri, 27 Oct 2017 23:23:55 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Mario Limonciello <Mario.Limonciello@...l.com>
Cc:     AceLan Kao <acelan.kao@...onical.com>,
        "dvhart@...radead.org" <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: dell-uart-backlight: new backlight driver
 for DELL AIO

On Fri, Oct 27, 2017 at 6:52 PM,  <Mario.Limonciello@...l.com> wrote:

>> and there is a new interface to deal with this kind of requirement, serdev.
>> But serdev is introduced after v4.12, to make it work before serdev, I
>> can't find other good solutions for it.
>
> Right, I know you have a need for this to work on older kernel too, so I think
> this interface as you did it makes sense on older kernel, but please do use serdev
> on newer kernel and as this is upstreamed.

Exactly, we don't care about old kernels in a new code.

>> >> +     /* unregister acpi backlight interface */
>> >> +     acpi_video_set_dmi_backlight_type(acpi_backlight_vendor);
>> >
>> > Since you change this when the driver is loaded, you should cache the old
>> > value and restore it when the driver is unloaded too.
>>
>> In this case, acpi backlight doesn't work, all the backlight
>> operations would go through UART commands.
>> So, it safe to remove it.
>
> OK.
> I think it would be good to include a command about this so that folks who
> look at this later understand this.

s/command/comment/ I suppose.

-- 
With Best Regards,
Andy Shevchenko