linux-kernel - RE: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Oct 2017 20:33:20 +0000
From:   Parav Pandit <parav@...lanox.com>
To:     Hal Rosenstock <hal@....mellanox.co.il>,
        Thomas Bogendoerfer <tbogendoerfer@...e.de>,
        Matan Barak <matanb@...lanox.com>,
        Leon Romanovsky <leonro@...lanox.com>,
        Doug Ledford <dledford@...hat.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Ghazale Hosseinabadi <ghazale.hosseinabadi@...cle.com>
Subject: RE: [PATCH] IB/mlx5: give back valid speed/width even without plugged
 in SFP module



> -----Original Message-----
> From: Hal Rosenstock [mailto:hal@....mellanox.co.il]
> Sent: Friday, October 27, 2017 3:19 PM
> To: Parav Pandit <parav@...lanox.com>; Thomas Bogendoerfer
> <tbogendoerfer@...e.de>; Matan Barak <matanb@...lanox.com>; Leon
> Romanovsky <leonro@...lanox.com>; Doug Ledford <dledford@...hat.com>;
> linux-rdma@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Ghazale Hosseinabadi <ghazale.hosseinabadi@...cle.com>
> Subject: Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged
> in SFP module
> 
> On 10/27/2017 2:32 PM, Parav Pandit wrote:
> > However I believe that ibstat tool should be enhanced to report unknown port
> speed instead of expecting drivers to supply some random number like this.
> 
> ibstat gets the rate from libibumad via /sys/class/infiniband/<IB
> device>/ports/<port number>/rate file which is supposed to be populated by the
> driver. Is there no rate file in this error case ?
> 
<...>/<port_num>/rate file exist.

rate_show() has invalid active_width as expected due to nonexistence of SFP.
So sysfs call return invalid value.
We don't have invalid_active_width defined right now.
So ibstat and other applications should not crash on such valid errors.