linux-kernel - Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <64ef31c8-cb1a-4579-ba12-11fbf6d1d5c0@default>
Date:   Fri, 27 Oct 2017 14:54:55 -0700 (PDT)
From:   Ghazale Hosseinabadi <ghazale.hosseinabadi@...cle.com>
To:     <hal@....mellanox.co.il>
Cc:     <linux-rdma@...r.kernel.org>, <tbogendoerfer@...e.de>,
        <matanb@...lanox.com>, <leonro@...lanox.com>, <parav@...lanox.com>,
        <linux-kernel@...r.kernel.org>, <dledford@...hat.com>
Subject: Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged
 in SFP module

Hi,

----- Original Message -----
From: hal@....mellanox.co.il
To: parav@...lanox.com, tbogendoerfer@...e.de, matanb@...lanox.com, leonro@...lanox.com, dledford@...hat.com, linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: ghazale.hosseinabadi@...cle.com
Sent: Friday, October 27, 2017 2:30:33 PM GMT -08:00 US/Canada Pacific
Subject: Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

On 10/27/2017 4:33 PM, Parav Pandit wrote:
> 
> 
>> -----Original Message-----
>> From: Hal Rosenstock [mailto:hal@....mellanox.co.il]
>> Sent: Friday, October 27, 2017 3:19 PM
>> To: Parav Pandit <parav@...lanox.com>; Thomas Bogendoerfer
>> <tbogendoerfer@...e.de>; Matan Barak <matanb@...lanox.com>; Leon
>> Romanovsky <leonro@...lanox.com>; Doug Ledford <dledford@...hat.com>;
>> linux-rdma@...r.kernel.org; linux-kernel@...r.kernel.org
>> Cc: Ghazale Hosseinabadi <ghazale.hosseinabadi@...cle.com>
>> Subject: Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged
>> in SFP module
>>
>> On 10/27/2017 2:32 PM, Parav Pandit wrote:
>>> However I believe that ibstat tool should be enhanced to report unknown port
>> speed instead of expecting drivers to supply some random number like this.
>>
>> ibstat gets the rate from libibumad via /sys/class/infiniband/<IB
>> device>/ports/<port number>/rate file which is supposed to be populated by the
>> driver. Is there no rate file in this error case ?
>>
> <...>/<port_num>/rate file exist.
> 
> rate_show() has invalid active_width as expected due to nonexistence of SFP.
> So sysfs call return invalid value.
> We don't have invalid_active_width defined right now.
> So ibstat and other applications should not crash on such valid errors.

Agreed. I haven't seen ibstat crash reported though. Can someone provide
the crash details ?

When running ibstat (if transceiver is not connected in adapter):

ibpanic: [7851] main: stat of IB device 'mlx5_1' failed: Invalid argument

Thanks,
Ghazale