linux-kernel - Re: [PATCH] input: mxs-lradc: remove redundant assignment to pointer input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171027224810.qd7pjnmhjlnqblkk@dtor-ws>
Date:   Fri, 27 Oct 2017 15:48:10 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Lee Jones <lee.jones@...aro.org>, linux-input@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: mxs-lradc: remove redundant assignment to pointer
 input

On Fri, Oct 27, 2017 at 04:52:30PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The pointer 'input' is being initialized with ts->ts_input and this
> value is not being read as it is updated a few lines later with the
> return value from the call to devm_input_allocate_device. Remove the
> redundant initialization assignment.  Cleans up clang warning:
> 
> drivers/input/touchscreen/mxs-lradc-ts.c:587:20: warning: Value Xi
> stored to 'input' during its initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thank you.

> ---
>  drivers/input/touchscreen/mxs-lradc-ts.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/mxs-lradc-ts.c b/drivers/input/touchscreen/mxs-lradc-ts.c
> index 3707e927f770..c850b517854e 100644
> --- a/drivers/input/touchscreen/mxs-lradc-ts.c
> +++ b/drivers/input/touchscreen/mxs-lradc-ts.c
> @@ -584,7 +584,7 @@ static void mxs_lradc_ts_hw_init(struct mxs_lradc_ts *ts)
>  
>  static int mxs_lradc_ts_register(struct mxs_lradc_ts *ts)
>  {
> -	struct input_dev *input = ts->ts_input;
> +	struct input_dev *input;
>  	struct device *dev = ts->dev;
>  
>  	input = devm_input_allocate_device(dev);
> -- 
> 2.14.1
> 

-- 
Dmitry