linux-kernel - Re: [GIT PULL] tracing/samples: Fix creation and deletion of simple_thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyR_FB=mYEgVnLmmkD_SLnSe9a28+LjOg=tPxj4gYtyhA@mail.gmail.com>
Date:   Fri, 27 Oct 2017 16:59:49 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        stable <stable@...r.kernel.org>
Subject: Re: [GIT PULL] tracing/samples: Fix creation and deletion of
 simple_thread_fn creation

I'm back home, which means I do full builds, and that in turn shows
that this was garbage.

On Tue, Oct 17, 2017 at 2:21 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
>
> Please pull the latest trace-v4.14-rc3 tree, which can be found at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
> trace-v4.14-rc3

This causes a compiler warning, for a very valid reason:

> +static bool simple_thread_cnt;
>
>  int foo_bar_reg(void)
>  {
> +       mutex_lock(&thread_mutex);
> +       if (simple_thread_cnt++)
> +               goto out;

Yeah., take a closer look at that. It's complete and utter BS.

Please send a fix asap, or I'll just revert.

                     Linus