linux-kernel - Re: can: Use common error handling code in vxcan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19ca5f23-fbb0-aaae-bff5-d634af66c264@users.sourceforge.net>
Date:   Sat, 28 Oct 2017 21:18:40 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Oliver Hartkopp <socketcan@...tkopp.net>,
        linux-can@...r.kernel.org, netdev@...r.kernel.org
Cc:     Marc Kleine-Budde <mkl@...gutronix.de>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: can: Use common error handling code in vxcan_newlink()

> If you want to change the semantic of the result check

I am curious if another source code reduction (by the deletion of “ < 0”)
will become acceptable at similar places.


> - this has to done consistently at all rtnl_configure_link() caller sites.

Are there any more functions to consider?


> And not only in vxcan.c

Are you interested in related adjustments for a bigger code base?

Regards,
Markus