linux-kernel - Re: [PATCH] i2c: generic recovery: check SCL before SDA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171028205546.g7hs4voihbzflfhe@ninjato>
Date:   Sat, 28 Oct 2017 22:55:46 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Claudio Foellmi <claudio.foellmi@...on.ch>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: generic recovery: check SCL before SDA

On Thu, Oct 05, 2017 at 02:44:14PM +0200, Claudio Foellmi wrote:
> Move the check for a stuck SCL before the check for a high SDA.
> This prevent false positives in the specific case that SDA is fine
> and SCL is stuck, which previously returned 0.
> 
> Also check SDA again after the loop, if we can.
> Together, these changes should lead to a lot more failed
> recoveries being caught and returning error codes.
> 
> Signed-off-by: Claudio Foellmi <claudio.foellmi@...on.ch>

Applied to for-next, thanks!

Huh, I thought we already fixed the add-SDA-check-after-loop, but seems
I was wrong :( I am not super happy with the now doubled SDA check, but
refactoring the whole loop is a seperate change IMO which can be done
later.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)