lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 28 Oct 2017 13:22:36 +0800 From: gengdongjiu <gengdongjiu@...wei.com> To: Marc Zyngier <marc.zyngier@....com> CC: "christoffer.dall@...aro.org" <christoffer.dall@...aro.org>, "linux@...linux.org.uk" <linux@...linux.org.uk>, "james.morse@....com" <james.morse@....com>, "tbaicar@...eaurora.org" <tbaicar@...eaurora.org>, "catalin.marinas@....com" <catalin.marinas@....com>, "will.deacon@....com" <will.deacon@....com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "kvmarm@...ts.cs.columbia.edu" <kvmarm@...ts.cs.columbia.edu>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] KVM: arm/arm64: Fix external abort type matching On 2017/10/28 2:28, Marc Zyngier wrote: >> kvm_vcpu_trap_get_fault_type() will clear the low two bits to zero. So >> I use FSC_SEA_TTW represent "Synchronous external abort on translation >> table walk" > I understand that, and I certainly not keen on adding another "fault > type" for this. Ok, thanks. > >> As we can see the Translation fault type "FSC_FAULT", which does not >> define the "FSC_FAULT0" "FSC_FAULT1" "FSC_FAULT2" "FSC_FAULT3". >> Because the fault type " FSC_FAULT " include the four cases. > Indeed, and I'm still not convinced this is the best thing we have in > the code. Ok, thanks. > >> static inline u8 kvm_vcpu_trap_get_fault(const struct kvm_vcpu *vcpu) >> { >> return kvm_vcpu_get_hsr(vcpu) & 0x3f; >> } > Here you go. This should give you a pretty good idea of how to provide a > proper fix. OK, got it, thanks > > Thanks,
Powered by blists - more mailing lists