linux-kernel - Re: [PATCH 10/17] hyper-v: trace vmbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171029205958.GA30187@kroah.com>
Date:   Sun, 29 Oct 2017 21:59:58 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     kys@...rosoft.com
Cc:     linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
        olaf@...fle.de, apw@...onical.com, vkuznets@...hat.com,
        jasowang@...hat.com, leann.ogasawara@...onical.com,
        marcelo.cerri@...onical.com, sthemmin@...rosoft.com
Subject: Re: [PATCH 10/17] hyper-v: trace vmbus_open()

On Sun, Oct 29, 2017 at 12:21:09PM -0700, kys@...hange.microsoft.com wrote:
> From: Vitaly Kuznetsov <vkuznets@...hat.com>
> 
> Add tracepoint to CHANNELMSG_OPENCHANNEL sender.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> ---
>  drivers/hv/channel.c  |  2 ++
>  drivers/hv/hv_trace.h | 27 +++++++++++++++++++++++++++
>  2 files changed, 29 insertions(+)
> 
> diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
> index a406beb10dd0..739b3fe1e0fb 100644
> --- a/drivers/hv/channel.c
> +++ b/drivers/hv/channel.c
> @@ -185,6 +185,8 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size,
>  	ret = vmbus_post_msg(open_msg,
>  			     sizeof(struct vmbus_channel_open_channel), true);
>  
> +	trace_vmbus_open(open_msg, ret);

Why add tracepoints for things that ftrace can handle automatically?