linux-kernel - Re: [PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171029212806.GA8470@kmp-mobile.hq.kempniu.pl>
Date:   Sun, 29 Oct 2017 22:28:06 +0100
From:   Michał Kępień <kernel@...pniu.pl>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Jonathan Woithe <jwoithe@...t42.net>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>, Harvey <harv@....de>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection

> On Wed, Oct 25, 2017 at 7:29 AM, Michał Kępień <kernel@...pniu.pl> wrote:
> > Radio LED detection method implemented in commit 4f62568c1fcf
> > ("fujitsu-laptop: Support radio LED") turned out to be incorrect as it
> > causes a radio LED to be erroneously detected on a Fujitsu Lifebook E751
> > which has a slide switch (and thus no radio LED).  Use bit 17 of
> > flags_supported (the value returned by method S000 of ACPI device
> > FUJ02E3) to determine whether a radio LED is present as it seems to be a
> > more reliable indicator, based on comparing DSDT tables of four Fujitsu
> > Lifebook models (E744, E751, S7110, S8420).
> >
> 
> Pushed to my review and testing queue, thanks!

I forgot that this patch can also be tagged with:

Fixes: 4f62568c1fcf ("fujitsu-laptop: Support radio LED")

-- 
Best regards,
Michał Kępień