linux-kernel - Re: [PATCH net-next] tools: bpftool: add bash completion for bpftool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 29 Oct 2017 18:38:08 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        oss-drivers@...ronome.com, daniel@...earbox.net,
        alexei.starovoitov@...il.com, quentin.monnet@...ronome.com
Subject: Re: [PATCH net-next] tools: bpftool: add bash completion for
 bpftool

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Thu, 26 Oct 2017 14:16:05 -0700

> From: Quentin Monnet <quentin.monnet@...ronome.com>
> 
> Add a completion file for bash. The completion function runs bpftool
> when needed, making it smart enough to help users complete ids or tags
> for eBPF programs and maps currently on the system.
> 
> Update Makefile to install completion file to
> /usr/share/bash-completion/completions when running `make install`.
> 
> Emacs file mode and (at the end) Vim modeline have been added, to keep
> the style in use for most existing bash completion files. In this, it
> differs from tools/perf/perf-completion.sh, which seems to be the only
> other completion file among the kernel sources repository. This is also
> valid for indent style: 4-space indents, as in other completion files.
> 
> Signed-off-by: Quentin Monnet <quentin.monnet@...ronome.com>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

I'll apply this for now.

If there are major objections I can revert.

Thanks.