linux-kernel - Re: [PATCH] staging: greybus: spilib: fix use-after-free after deregistration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171029125159.GA659@localhost>
Date:   Sun, 29 Oct 2017 13:51:59 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Johan Hovold <johan@...nel.org>,
        Rui Miguel Silva <rmfrfs@...il.com>,
        Viresh Kumar <vireshk@...nel.org>,
        Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        greybus-dev@...ts.linaro.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, stable <stable@...r.kernel.org>
Subject: Re: [PATCH] staging: greybus: spilib: fix use-after-free after
 deregistration

On Sun, Oct 29, 2017 at 06:13:28PM +0530, Viresh Kumar wrote:
> On 29-10-17, 13:01, Johan Hovold wrote:
> > Remove erroneous spi_master_put() after controller deregistration which
> > would access the already freed spi controller.
> > 
> > Note that spi_unregister_master() drops our only controller reference.
> > 
> > Fixes: ba3e67001b42 ("greybus: SPI: convert to a gpbridge driver")
> > Cc: stable <stable@...r.kernel.org>     # 4.9
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Signed-off-by: Johan Hovold <johan@...nel.org>

> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> 
> While looking at this I think I found another problem (I will send it as a
> separate patch later on) and this fixes it:

That's right, and I already posted a fix for that use-after-free:

	https://lkml.kernel.org/r/20171029115625.32385-1-johan@kernel.org

Thanks,
Johan