linux-kernel - Re: [PATCH linux-next 1/1] ASoC: rsnd: ssiu: reset SSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o9oprrl3.wl%kuninori.morimoto.gx@renesas.com>
Date:   Mon, 30 Oct 2017 08:10:58 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Jiada Wang <jiada_wang@...tor.com>
Cc:     <lgirdwood@...il.com>, <broonie@...nel.org>, <perex@...ex.cz>,
        <tiwai@...e.com>, <gustavo@...eddedor.com>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH linux-next 1/1] ASoC: rsnd: ssiu: reset SSI_MODE register


Hi Jiada

> > ------------------
> > diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c
> > index 4d94875..8dc2e92 100644
> > --- a/sound/soc/sh/rcar/ssiu.c
> > +++ b/sound/soc/sh/rcar/ssiu.c
> > @@ -130,14 +130,13 @@ static int rsnd_ssiu_init_gen2(struct rsnd_mod *mod,
> >  	if (ret < 0)
> >  		return ret;
> >
> > -	if (rsnd_runtime_is_ssi_tdm(io)) {
> > -		/*
> > -		 * TDM Extend Mode
> > -		 * see
> > -		 *	rsnd_ssi_config_init()
> > -		 */
> > -		rsnd_mod_write(mod, SSI_MODE, 0x1);
> > -	}
> > +	/*
> > +	 * TDM Extend Mode
> > +	 * see
> > +	 *	rsnd_ssi_config_init()
> > +	 */
> > +	rsnd_mod_write(mod, SSI_MODE,
> > +		       rsnd_runtime_is_ssi_tdm(io) ? 0x1 : 0x0);
> 
> Thanks for your suggestion,
> I will do some test for this change,
> if it works fine, I will submit ver2 with it

Thanks

Best regards
---
Kuninori Morimoto