linux-kernel - Re: [locking/paravirt] static_key_disable_cpuslocked(): static key 'virt_spin_lock_key+0x0/0x20' used before call to jump_label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171030083835.kirbygtl3qneg6ab@wfg-t540p.sh.intel.com>
Date:   Mon, 30 Oct 2017 09:38:35 +0100
From:   Fengguang Wu <fengguang.wu@...el.com>
To:     Juergen Gross <jgross@...e.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Waiman Long <longman@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>, akataria@...are.com,
        boris.ostrovsky@...cle.com, chrisw@...s-sol.org, hpa@...or.com,
        jeremy@...p.org, rusty@...tcorp.com.au,
        virtualization@...ts.linux-foundation.org,
        xen-devel@...ts.xenproject.org
Subject: Re: [locking/paravirt] static_key_disable_cpuslocked(): static key
 'virt_spin_lock_key+0x0/0x20' used before call to jump_label_init()

On Mon, Oct 30, 2017 at 08:47:08AM +0100, Juergen Gross wrote:
>On 30/10/17 08:35, Fengguang Wu wrote:
>> On Sun, Oct 29, 2017 at 11:51:55PM +0100, Fengguang Wu wrote:
>>> Hi Linus,
>>>
>>> Up to now we see the below boot error/warnings when testing v4.14-rc6.
>>>
>>> They hit the RC release mainly due to various imperfections in 0day's
>>> auto bisection. So I manually list them here and CC the likely easy to
>>> debug ones to the corresponding maintainers in the followup emails.
>>>
>>> boot_successes: 4700
>>> boot_failures: 247
>>
>> [...]
>>
>>> WARNING:at_kernel/jump_label.c:#static_key_disable_cpuslocked: 7
>
>This patch is in the tip tree only, it will be merged in 4.15. So I
>don't understand why you are reporting this for 4.14-rc6.

Ah sorry, I simply checked recent bisects for that warning.
Then I'll need to carry out some new bisect on 4.14-rc6.

>There is a patch by Dou Liyang pending since 28th October addressing
>that issue:
>
>[PATCH tip v2] x86/paravirt: Make the virt_spin_lock_key setup after
>jump_label_init()

Excellent!

Thanks,
Fengguang