linux-kernel - Re: [PATCH] usb: musb_core: mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171030085118.GA28997@kroah.com>
Date:   Mon, 30 Oct 2017 09:51:18 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Bin Liu <b-liu@...com>,
        "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: musb_core: mark expected switch fall-through

On Fri, Oct 27, 2017 at 11:56:14AM -0500, Bin Liu wrote:
> On Fri, Oct 27, 2017 at 06:49:49PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Oct 27, 2017 at 11:44:47AM -0500, Bin Liu wrote:
> > > Hi,
> > > 
> > > On Mon, Oct 23, 2017 at 10:10:43PM -0500, Gustavo A. R. Silva wrote:
> > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > > > where we are expecting to fall through.
> > > > 
> > > > Addresses-Coverity-ID: 1397608
> > > > Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> > > 
> > > Applied with the above Coverity-ID message removed.
> > 
> > Why?  It's good to track these things.
> 
> hmm, I thought we don't want non-kernel related information in the commit
> message.

This is kernel-related information.

We don't want foolish "Id:" lines, from gerrit instances, as they are no
help at all because we can not do anything with them.

We _do_ want identifiers that are globally unique that provide real
information, like public bugzilla ids, and tools like coverity.  So for
things like this, always keep them on.

I've added it back by hand now.

thanks,

greg k-h