linux-kernel - Re: gma500: mmu: unmap the correct address

Open Source and information security mailing list archives

Message-ID: <20171030102224.55gyvgehpwzgn2f6@phenom.ffwll.local>
Date:   Mon, 30 Oct 2017 11:22:24 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Pan Bian <bianpan2016@....com>
Cc:     Patrik Jakobsson <patrik.r.jakobsson@...il.com>,
        David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: gma500: mmu: unmap the correct address

On Sun, Oct 29, 2017 at 01:55:12PM +0800, Pan Bian wrote:
> The function kunmap_atomatic() is called on the same variable twice,
> i.e. pt->v. In the second call, its parameter should be variable v
> rather than pt->v.
> 
> Signed-off-by: Pan Bian <bianpan2016@....com>

Makes sense, not sure this ever worked or how it ever worked, but oh well.

Applied to drm-misc-next for 4.16.
-Daniel

> ---
>  drivers/gpu/drm/gma500/mmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/gma500/mmu.c b/drivers/gpu/drm/gma500/mmu.c
> index 0eaf11c..ccb161c 100644
> --- a/drivers/gpu/drm/gma500/mmu.c
> +++ b/drivers/gpu/drm/gma500/mmu.c
> @@ -395,7 +395,7 @@ static void psb_mmu_pt_unmap_unlock(struct psb_mmu_pt *pt)
>  			psb_mmu_clflush(pd->driver, (void *)&v[pt->index]);
>  			atomic_set(&pd->driver->needs_tlbflush, 1);
>  		}
> -		kunmap_atomic(pt->v);
> +		kunmap_atomic(v);
>  		spin_unlock(&pd->driver->lock);
>  		psb_mmu_free_pt(pt);
>  		return;
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives