linux-kernel - Re: [PATCH] mmc: tmio: Use common error handling code in tmio_mmc_host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 30 Oct 2017 12:40:33 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mmc: tmio: Use common error handling code in tmio_mmc_host_probe()

On 27 October 2017 at 19:17, SF Markus Elfring
<elfring@...rs.sourceforge.net> wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 27 Oct 2017 19:09:17 +0200
>
> * Add a jump target so that a bit of exception handling can be better
>   reused at the end of this function.
>
> * Adjust condition checks.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/tmio_mmc_core.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
> index a7293e186e03..2e85d4048cec 100644
> --- a/drivers/mmc/host/tmio_mmc_core.c
> +++ b/drivers/mmc/host/tmio_mmc_core.c
> @@ -1286,23 +1286,24 @@ int tmio_mmc_host_probe(struct tmio_mmc_host *_host,
>         pm_runtime_enable(&pdev->dev);
>
>         ret = mmc_add_host(mmc);
> -       if (ret < 0) {
> -               tmio_mmc_host_remove(_host);
> -               return ret;
> -       }
> +       if (ret)
> +               goto remove_host;
>
>         dev_pm_qos_expose_latency_limit(&pdev->dev, 100);
>
>         if (pdata->flags & TMIO_MMC_USE_GPIO_CD) {
>                 ret = mmc_gpio_request_cd(mmc, pdata->cd_gpio, 0);
> -               if (ret < 0) {
> -                       tmio_mmc_host_remove(_host);
> -                       return ret;
> -               }
> +               if (ret)
> +                       goto remove_host;
> +
>                 mmc_gpiod_request_cd_irq(mmc);
>         }
>
>         return 0;
> +
> +remove_host:
> +       tmio_mmc_host_remove(_host);
> +       return ret;
>  }
>  EXPORT_SYMBOL_GPL(tmio_mmc_host_probe);
>
> --
> 2.14.3
>