linux-kernel - Re: [PATCH stable-4.1.y] tools include: Add a _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171030030354.fifvokpkcp4g2pdw@sasha-lappy>
Date:   Mon, 30 Oct 2017 03:03:56 +0000
From:   "Levin, Alexander (Sasha Levin)" <alexander.levin@...izon.com>
To:     Florian Fainelli <f.fainelli@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        David Ahern <dsahern@...il.com>, Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Wang Nan <wangnan0@...wei.com>,
        William Cohen <wcohen@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH stable-4.1.y] tools include: Add a __fallthrough statement

On Fri, Oct 27, 2017 at 12:05:58PM -0700, Florian Fainelli wrote:
>From: Arnaldo Carvalho de Melo <acme@...hat.com>
>
>commit b5bf1733d6a391c4e90ea8f8468d83023be74a2a upstream.
>
>For cases where implicit fall through case labels are intended,
>to let us inform that to gcc >= 7:
>
>    CC       /tmp/build/perf/util/string.o
>  util/string.c: In function 'perf_atoll':
>  util/string.c:22:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
>      if (*p)
>         ^
>  util/string.c:24:3: note: here
>     case '\0':
>     ^~~~
>
>So we introduce:
>
>  #define __fallthrough __attribute__ ((fallthrough))
>
>And use it in such cases.

Queued up, thanks!

-- 

Thanks,
Sasha