linux-kernel - Re: [PATCH] hw_random: Include device.h instead of declaring struct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANc+2y4Lepxa+9X4ZAB68uuAyUBzTkd00DqjQGU8du-1FijbTA@mail.gmail.com>
Date:   Mon, 30 Oct 2017 18:30:53 +0530
From:   PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hw_random: Include device.h instead of declaring struct device

Hi Herbert,

On 30 October 2017 at 12:22, Herbert Xu <herbert@...dor.apana.org.au> wrote:
> On Thu, Oct 26, 2017 at 07:12:08PM +0530, PrasannaKumar Muralidharan wrote:
>> Include linux/device.h instead of declaring struct device.
>>
>> Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>
>
> Nack.  We should not include a header file when a simple forward
> declaration is enough.

No issues.

Regards,
PrasannaKumar