linux-kernel - Re: [PATCH 2/5] wlcore: Delete an unnecessary check statement in wlcore_set_beacon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGRGNgWFgg5oyRcgP6mp--oF6VPcD1k13SyKmmK3cc8KPC05BQ@mail.gmail.com>
Date:   Tue, 31 Oct 2017 00:26:16 +1100
From:   Julian Calaby <julian.calaby@...il.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-wireless <linux-wireless@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        Arend Van Spriel <arend.vanspriel@...adcom.com>,
        Eyal Reizer <eyalr@...com>, Iain Hunter <drhunter95@...il.com>,
        James Minor <james.minor@...com>,
        Johannes Berg <johannes.berg@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        Maxim Altshul <maxim.altshul@...com>,
        Pieter-Paul Giesberts <pieter-paul.giesberts@...adcom.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 2/5] wlcore: Delete an unnecessary check statement in wlcore_set_beacon_template()

On Mon, Oct 30, 2017 at 7:12 AM, SF Markus Elfring
<elfring@...rs.sourceforge.net> wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 29 Oct 2017 19:45:07 +0100
>
> A goto statement jumped to a target which followed a condition check
> immediately without the specification of useful actions between.
> Thus remove such unnecessary source code at the end of this function.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Looks good to me.

Reviewed-by: Julian Calaby <julian.calaby@...il.com>

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/