linux-kernel - Re: [PATCH v3 04/12] arm: vdso: enforce monotonic and realtime as inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171030141004.n54obxkbmtfbzmra@lakrids.cambridge.arm.com>
Date:   Mon, 30 Oct 2017 14:10:05 +0000
From:   Mark Rutland <mark.rutland@....com>
To:     Mark Salyzyn <salyzyn@...roid.com>
Cc:     linux-kernel@...r.kernel.org, James Morse <james.morse@....com>,
        Russell King <linux@...linux.org.uk>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Andy Lutomirski <luto@...capital.net>,
        Dmitry Safonov <dsafonov@...tuozzo.com>,
        John Stultz <john.stultz@...aro.org>,
        Laura Abbott <labbott@...hat.com>,
        Kees Cook <keescook@...omium.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Andy Gross <andy.gross@...aro.org>,
        Kevin Brodsky <kevin.brodsky@....com>,
        Andrew Pinski <apinski@...ium.com>,
        linux-arm-kernel@...ts.infradead.org,
        Mark Salyzyn <salyzyn@...gle.com>
Subject: Re: [PATCH v3 04/12] arm: vdso: enforce monotonic and realtime as
 inline

On Fri, Oct 27, 2017 at 03:25:28PM -0700, Mark Salyzyn wrote:
> Ensure monotonic and realtime are inline, small price to pay for
> high volume common request.

Does this make a noticeable difference on any workload?

What does this do to the binary size?

Thanks,
Mark.

> 
> Signed-off-by: Mark Salyzyn <salyzyn@...roid.com>
> Cc: James Morse <james.morse@....com>
> Cc: Russell King <linux@...linux.org.uk>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will.deacon@....com>
> Cc: Andy Lutomirski <luto@...capital.net>
> Cc: Dmitry Safonov <dsafonov@...tuozzo.com>
> Cc: John Stultz <john.stultz@...aro.org>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Laura Abbott <labbott@...hat.com>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> Cc: Andy Gross <andy.gross@...aro.org>
> Cc: Kevin Brodsky <kevin.brodsky@....com>
> Cc: Andrew Pinski <apinski@...ium.com>
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-arm-kernel@...ts.infradead.org
> 
> v2:
> - split first CL into 4 of 7 pieces
> 
> v3:
> - rebase (unchanged)
> 
> ---
>  arch/arm/vdso/vgettimeofday.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/vdso/vgettimeofday.c b/arch/arm/vdso/vgettimeofday.c
> index 5f596911bd53..71003a1997c4 100644
> --- a/arch/arm/vdso/vgettimeofday.c
> +++ b/arch/arm/vdso/vgettimeofday.c
> @@ -99,7 +99,7 @@ static notrace int do_monotonic_coarse(const struct vdso_data *vd,
>  
>  #ifdef CONFIG_ARM_ARCH_TIMER
>  
> -static notrace u64 get_ns(const struct vdso_data *vd)
> +static __always_inline notrace u64 get_ns(const struct vdso_data *vd)
>  {
>  	u64 cycle_delta;
>  	u64 cycle_now;
> @@ -115,7 +115,9 @@ static notrace u64 get_ns(const struct vdso_data *vd)
>  	return nsec;
>  }
>  
> -static notrace int do_realtime(const struct vdso_data *vd, struct timespec *ts)
> +/* Code size doesn't matter (vdso is 4k/16k/64k anyway) and this is faster. */
> +static __always_inline notrace int do_realtime(const struct vdso_data *vd,
> +					       struct timespec *ts)
>  {
>  	u64 nsecs;
>  	u32 seq;
> @@ -137,7 +139,8 @@ static notrace int do_realtime(const struct vdso_data *vd, struct timespec *ts)
>  	return 0;
>  }
>  
> -static notrace int do_monotonic(const struct vdso_data *vd, struct timespec *ts)
> +static __always_inline notrace int do_monotonic(const struct vdso_data *vd,
> +						struct timespec *ts)
>  {
>  	struct timespec tomono;
>  	u64 nsecs;
> -- 
> 2.15.0.rc2.357.g7e34df9404-goog
>