linux-kernel - Re: [PATCH] nlm_shutdown_hosts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171030144943.GG14098@fieldses.org>
Date:   Mon, 30 Oct 2017 10:49:43 -0400
From:   "J. Bruce Fields" <bfields@...ldses.org>
To:     Vasily Averin <vvs@...tuozzo.com>
Cc:     linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jeff Layton <jlayton@...chiereds.net>
Subject: Re: [PATCH] nlm_shutdown_hosts_net() cleanup

On Mon, Oct 30, 2017 at 04:47:58PM +0300, Vasily Averin wrote:
> nlm_complain_hosts() walk through nlm_server_hosts hlist that should be
> protected by nlm_host_mutex.

I haven't looked at the NLM locking in ages.  Do we know who else might
actually be accessing this list concurrently?

--b.

> 
> Signed-off-by: Vasily Averin <vvs@...tuozzo.com>
> ---
>  fs/lockd/host.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/lockd/host.c b/fs/lockd/host.c
> index d716c99..089c1d7 100644
> --- a/fs/lockd/host.c
> +++ b/fs/lockd/host.c
> @@ -617,9 +617,8 @@ nlm_shutdown_hosts_net(struct net *net)
>  
>  	/* Then, perform a garbage collection pass */
>  	nlm_gc_hosts(net);
> -	mutex_unlock(&nlm_host_mutex);
> -
>  	nlm_complain_hosts(net);
> +	mutex_unlock(&nlm_host_mutex);
>  }
>  
>  /*
> -- 
> 2.7.4